tsdb/errors.MultiError: support errors.As #16544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the multierror was hiding some errors in Mimir. I also added unit tests because I had them handy from a similar change I and yuri did in XXX and some time ago Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
4 tasks
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
aknuds1
approved these changes
May 3, 2025
|
Would it help solve this ? Lines 69 to 71 in e7e3ab2 |
|
@mmorel-35 I'm really not sure. How would the two be connected? @dimitarvdimitrov Would you know? |
|
When I enabled errorlint on the code base, I got stuck on that part , I'm not sure but it might be due to the fact that MultiError was not supporting errors.As correctly. It's the occasion to check on that. |
|
This is related to errors.As on wlog.CorruptionErr sorry for the trouble |
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
aknuds1
approved these changes
May 6, 2025
Shuimo03
pushed a commit
to Shuimo03/prometheus
that referenced
this pull request
May 8, 2025
* tsdb/errors.MultiError: implement Unwrap the multierror was hiding some errors in Mimir. I also added unit tests because I had them handy from a similar change I and yuri did in XXX and some time ago --------- Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: WuLiang <wu1998102@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the multierror was hiding some errors in Mimir. I also added unit tests because I had them handy from a similar change I and @duricanikolic did in grafana/dskit#522 and grafana/dskit#254 some time ago.