[BUGFIX] Top-level: Update GOGC before loading TSDB #16491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should use the configured value, or Prometheus' default of 75%, while initializing and loading the WAL. Since the Go default is 100%, most Prometheus users would experience higher memory usage before the value is configured. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
machine424
reviewed
Apr 29, 2025
There was a problem hiding this comment.
nice catch! Hopefully GOMEMLIMIT is around.
I was misled by the fact that the config reload and the DB opening happen concurrently, I missed that one actually waits for the other.
I will simplify the tests in #15238 (no need to wait for readiness) and we can have that merged as well.
(I don't think checking when the config takes place is worth it as a test )
E.g. if a module starting up looks at GOMAXPROCS to size something, we need to have set it already. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use the configured value, or Prometheus' default of 75%, while initializing and loading the WAL.
Since the Go default is 100%, most Prometheus users would experience higher memory usage before the value is configured.