Use stringlabels by default #16436
Merged
Use stringlabels by default #16436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the stringlabels build tag, makes that implementation the default one, and moves the old labels implementation under the slicelabels build tag. Fixes prometheus#16064. Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>
Mostly comment issues and unused variables. Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>
Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>
machine424
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR makes the stringlabels implementation the default by removing the stringlabels build tag and shifts the old implementation under the slicelabels build tag, fixing #16064. Key changes include updating test functions to reflect the new default label collision behavior, revising build tags in multiple label-related files, and adjusting CI configuration to remove the stringlabels flag.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tsdb/head_test.go | Updates expected hash collision inputs for label tests. |
| tsdb/agent/series_test.go | Mirrors head_test.go label collision adjustments for agent tests. |
| model/labels/*.go | Revises build tags and updates comments to match new defaults. |
| .promu.yml and .github/workflows/ci.yml | Removes stringlabels flag from build configurations and tests. |
Comments suppressed due to low confidence (2)
tsdb/head_test.go:6289
- [nitpick] There is a change in the label key from 'lbl1' in the fallback assignment to 'lbl' in the initial assignment. Please confirm that using 'lbl' initially and 'lbl1' later is intentional to differentiate behaviors between the default (slicelabels) and legacy implementations.
ls1 := labels.FromStrings("__name__", "metric", "lbl", "HFnEaGl")
tsdb/agent/series_test.go:80
- [nitpick] The label key changes between the initial assignment and the fallback (using 'lbl1' and 'lbl2') may be confusing. Please verify that this inconsistency is expected as part of the change in default label handling.
ls1 := labels.FromStrings("__name__", "metric", "lbl", "HFnEaGl")
bboreham
approved these changes
Apr 25, 2025
bboreham
reviewed
May 1, 2025
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
May 16, 2025
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
May 16, 2025
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
May 16, 2025
* Upgrade mimir-prometheus * Fix breaking change in `NewAPI` * Sync upstream PromQL engine test cases * Modify `histogram_stddev` and `histogram_stdvar` to match new behaviour introduced in prometheus/prometheus#16444 * Simplify code * Remove outdated comment This issue was fixed in prometheus/prometheus#15828. * Remove unnecessary variable * Rename operator and files * Extract `histogram_quantile`-specific logic * Add support for classic histograms in `histogram_fraction` See prometheus/prometheus#16095 * Bring in changes from grafana/mimir-prometheus#871 * Invert build tag logic to match prometheus/prometheus#16436 * Sync query engine tests with upstream * Fix breaking changes * Regenerate OTLP code
32 tasks
Closed
1 task
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the stringlabels build tag, makes that implementation the default one, and moves the old labels implementation under the slicelabels build tag. Fixes #16064.