TSDB: don't process exemplars older than minValidTime during WAL replay #16242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patryk Prus <p@trykpr.us>
bboreham
approved these changes
Mar 20, 2025
This was referenced Mar 24, 2025
zenador
pushed a commit
to zenador/prometheus
that referenced
this pull request
Jun 2, 2025
TSDB: don't process exemplars older than minValidTime during WAL replay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For float and histogram samples (and tombstones) we check the timestamp of the record against the minValidTime of the head before attempting any other processing, skipping the record entirely if minValidTime is greater. For exemplars, we don't do this check until after we try to match the exemplar record to a series (possibly logging unknown series references for exemplars that we're going to skip processing anyway).
This PR moves the timestamp check to be the first thing done when processing exemplar records, matching the other record types.