[PERF] TSDB: Pass down label value limit into implementation #16158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df806b5 to
d4c107f
Compare
d4c107f to
243212f
Compare
Signed-off-by: Andre Branchizio <andrejbranch@gmail.com>
243212f to
68cd106
Compare
|
Let's reference #14109 as priory art. |
bboreham
reviewed
Mar 11, 2025
Signed-off-by: Andre Branchizio <andrejbranch@gmail.com>
|
BTW the description is a bit confusing to me as someone who doesn't work on Thanos. |
Shuimo03
pushed a commit
to Shuimo03/prometheus
that referenced
this pull request
May 8, 2025
…eus#16158) * allow limiting label values calls Signed-off-by: Andre Branchizio <andrejbranch@gmail.com> Signed-off-by: WuLiang <wu1998102@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows limiting the result sets of values calls, which can significantly reduce the payload for high cardinality metrics with 100k+ values.
A next step to this might be getting values in batches here and intersecting the postings batch by batch until limit is reached which could improve memory and latency for calls that have a specified limit. Though this seems like a reasonable starting point.