[FIX] PromQL: Updates annotation for bin op between incompatible histograms #15895
Conversation
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
Rather than writing fairly involved tests for that right now, let's first implement #15794 . (But I also don't want to block this PR waiting for it.) |
As of now we can only test that there is a warning. We cannot test the actual warn message. Although I can attach Screenshot of the warning message ( for a failing test ). |
|
I mean, you could write a conventional unit test for this, not using the testing framework. But I think this work should better be invested in solving #15794 . This is not touching the actual result, it's just about an annotations. Your change is surely not making things worse, so I'm fine to merge this without test. You should probably add a comment to add an explicit test once #15794 is resolved. (BTW: I still have to look at the actual code here. It's on my list…) |
Ah, I forgot that conventional tests can be added as well :)
Yeah, I'll add a comment. Don't we need to do that for almost all the |
In principle yes, but this case here might be particularly important because we had a problem before. |
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
* Upgrade mimir-prometheus * Bring in upstream test changes * Apply change to match prometheus/prometheus#15974 * Remove test case added in upstream in prometheus/prometheus#15975 * Add tests for case where range vector selectors and subqueries have 0 range Brings in change from #10586 * Update `sort` and `sort_desc` behaviour to match prometheus/prometheus#15964 * Add support for native histograms to `irate` and `idelta` to match prometheus/prometheus#15853 * Adjust test cases to match support for native histograms in `irate` and `idelta` * Change binop annotations to match behaviour in prometheus/prometheus#15895 * Ignore incompatible schemas between the first and second point in `rate` and `increase` if the second point is a reset (prometheus/prometheus#15902) * Adjust annotation test cases to match new behaviour introduced in previous commit * Disable tests failing due to prometheus/prometheus#16199 * Add changelog entry * Update `TestQuerySharding_FunctionCorrectness` to reflect changes in prometheus/prometheus#15964
Resolves #14669
CC: @beorn7 @charleskorn