Skip to content

Optionally translate OTel histograms to NHCB #15850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 20, 2025
Merged

Optionally translate OTel histograms to NHCB #15850

merged 12 commits into from
Mar 20, 2025

Conversation

carrieedwards
Copy link
Contributor

@carrieedwards carrieedwards commented Jan 21, 2025 •
edited
Loading

This PR adds the functionality to convert OTel explicit histograms into Custom Buckets Native Histograms via a configuration option.

Issue: #15022
Part of: #13485

@carrieedwards carrieedwards force-pushed the cedwards/otel-hist-to-nhcb branch from 8cb4d0c to 5489b67 Compare January 21, 2025 16:28
@bwplotka
Copy link
Member

Nice, good idea!

@krajorama krajorama self-requested a review March 5, 2025 15:00
krajorama
krajorama reviewed Mar 10, 2025
View reviewed changes
Copy link
Member

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. For this to work end-to-end we'll have to update

prometheus/prompb/codec.go

Line 99 in e32d89a

func (h Histogram) ToFloatHistogram() *histogram.FloatHistogram {

and

prometheus/prompb/codec.go

Line 78 in e32d89a

func (h Histogram) ToIntHistogram() *histogram.Histogram {

@krajorama
Copy link
Member

Also we'll probably need a setting to limit maximum bucket count - and error out if it we go over.

krajorama
krajorama reviewed Mar 10, 2025
View reviewed changes
@carrieedwards carrieedwards force-pushed the cedwards/otel-hist-to-nhcb branch 2 times, most recently from 46a35c2 to e3edb69 Compare March 17, 2025 21:34
@carrieedwards carrieedwards marked this pull request as ready for review March 18, 2025 15:51
aknuds1
aknuds1 reviewed Mar 18, 2025
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, but see comments :)

aknuds1
aknuds1 reviewed Mar 18, 2025
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the new convert_histograms_to_nhcb configuration parameter to docs/configuration/configuration.md? Also, should there be a FEATURE changelog entry?

@aknuds1
Copy link
Contributor

aknuds1 commented Mar 18, 2025

A conflict needs resolving.

@carrieedwards carrieedwards force-pushed the cedwards/otel-hist-to-nhcb branch from ca7fbed to 835eb94 Compare March 18, 2025 22:27
@aknuds1 aknuds1 self-requested a review March 19, 2025 05:02
aknuds1
aknuds1 approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! LGTM, except you should fix the changelog ordering.

krajorama
krajorama approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carrieedwards
Optionally translate OTEL histograms to NHCB
59bbde7 
Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>
@carrieedwards
Add tests for explicit histogram to NHCB translation
716b3f7 
Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>
@carrieedwards
Linting
2cb4e97 
Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>
@carrieedwards
Add test for translation with flag
e417fbb 
Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>
@carrieedwards
Refactor to re-use bucket conversion function
2f5d227 
Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>
@carrieedwards
Update prompb
d9560ff 
Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>
@carrieedwards
Add comment explaining explicit bounds and use defined CustomBucketSc…
18fbc02 
…hema

Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>
@carrieedwards
Add TODO for limiting max bucket count
1eea7f5 
Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>
@carrieedwards
Fix imports and remove extra blank line
057a55a 
Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>
@carrieedwards
Update configuration docs and CHANGELOG
dba52a4 
Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>
@carrieedwards
Update CHANGELOG
e001624 
Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>
@carrieedwards
Use otlptranslator package
84bdc4f 
Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>
@carrieedwards carrieedwards force-pushed the cedwards/otel-hist-to-nhcb branch from f9efbe1 to 84bdc4f Compare March 20, 2025 15:45
@carrieedwards carrieedwards changed the title Optionally translate OTEL histograms to NHCB Optionally translate OTel histograms to NHCB Mar 20, 2025
@carrieedwards carrieedwards merged commit c90b387 into main Mar 20, 2025
46 checks passed
@carrieedwards carrieedwards deleted the cedwards/otel-hist-to-nhcb branch March 20, 2025 16:18
@carrieedwards carrieedwards mentioned this pull request Mar 20, 2025
Closed
This was referenced Mar 24, 2025
Merged
Merged
@carrieedwards carrieedwards mentioned this pull request Apr 1, 2025
Merged
4 tasks
slashpai added a commit to slashpai/prometheus-operator that referenced this pull request May 17, 2025
@slashpai
feat: add convertHistogramsToNHCB field to OTLPConfig
91ce819 
Related-to prometheus/prometheus#15850

Signed-off-by: Jayapriya Pai <slashpai9@gmail.com>
@slashpai slashpai mentioned this pull request May 17, 2025
Merged
5 tasks
@jmichalek132 jmichalek132 mentioned this pull request Jun 7, 2025
Merged
2 tasks
@krajorama krajorama mentioned this pull request Jul 2, 2025
Closed
@ArthurSens ArthurSens mentioned this pull request Jul 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknuds1 aknuds1 aknuds1 approved these changes

@krajorama krajorama krajorama approved these changes

@jesusvazquez jesusvazquez Awaiting requested review from jesusvazquez jesusvazquez is a code owner

@cstyan cstyan Awaiting requested review from cstyan cstyan is a code owner

@bwplotka bwplotka Awaiting requested review from bwplotka bwplotka is a code owner

@tomwilkie tomwilkie Awaiting requested review from tomwilkie tomwilkie is a code owner

Assignees
No one assigned
Labels
area/opentelemetry kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carrieedwards @bwplotka @krajorama @aknuds1