promql: fix "cannot reduce resolution to custom buckets schema" panic in rate over native histograms with mix of custom and exponential buckets
#14609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Korn <charles.korn@grafana.com>
…e` over native histograms with mix of custom and exponential buckets Signed-off-by: Charles Korn <charles.korn@grafana.com>
9a0874d to
424cefc
Compare
Merged
2 tasks
|
Thank you. Related to #13494 |
|
Also somewhat related: #14168 |
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Aug 8, 2024
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Aug 8, 2024
charleskorn
added a commit
to grafana/mimir
that referenced
this pull request
Aug 8, 2024
…tions (#8924) * Enable histogram test cases. * Enable test cases we now support * Emit warnings from `rate` and `sum` if a custom and exponential buckets are seen at the same timestamp, or if incompatible custom buckets are seen at the same timestamp * Add changelog entry # Conflicts: # CHANGELOG.md * Address PR feedback: move custom bucket check earlier in `rate` * Address PR feedback: clarify comments * Address PR feedback: extend test case range to include samples after an ignored sample * Skip `TestAnnotations` test case that fails on Prometheus' engine due to prometheus/prometheus#14609 * Skip test cases that fail on Prometheus' engine due to prometheus/prometheus#14611 * Fix failing test
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
rateis used over a range of native histograms with both custom and exponential buckets, a panic can occur.I've also modified the behaviour of the test scripting language to check for query errors before warnings: if the query failed to evaluate, it's more useful to see the failure rather than the fact that warnings were or weren't present.