Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Jan 28, 2020

No description provided.

@posva
Copy link
Owner

posva commented Jan 28, 2020

Thanks but the current version is correct

@posva posva closed this Jan 28, 2020
@ghost
Copy link
Author

ghost commented Jan 29, 2020

Doesnt feel like it but anyways.

@ghost
Copy link
Author

ghost commented Jan 29, 2020

@posva Actually i am sure that you are wrong. There are some special situation normal rules doesn't apply because of pronunciation. ForEx:
An hour.
A usecase.

@posva
Copy link
Owner

posva commented Jan 29, 2020

For some reason I thought the PR introduced an usecase to replace a usecase and not the other way around 🤦‍♂️
Thanks!

@posva posva reopened this Jan 29, 2020
@posva posva merged commit 97de59d into posva:router/dynamic-routing Jan 29, 2020
posva added a commit that referenced this pull request Apr 30, 2020
* Dynamic Routing

* precision from

* add getRoutes

* add alternative for getRoutes

* fix: typo in 0000-router-dynamic-routing.md (#1)

* fix typo (#2)

* Update 0000-router-dynamic-routing.md (#3)

Just some grammatical corrections. Hope you don't mind.

Scott

* remove template drawbacks

* update

* rename Symbol to symbol, type typo

* rename

Co-authored-by: pierresaid <said.pierre.emler@gmail.com>
Co-authored-by: atilkan <emrahatilkan@gmail.com>
Co-authored-by: Scott <smolinari@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants