Skip to content

fix(SimpleFileChannel): unify default "flush" to be false as it is in FileChannel #4622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2024
Merged

fix(SimpleFileChannel): unify default "flush" to be false as it is in FileChannel #4622

merged 1 commit into from
Aug 17, 2024

Conversation

matejk
Copy link
Contributor

@matejk matejk commented Jul 30, 2024

Closes #4591.

@matejk matejk added this to the Release 1.14.0 milestone Jul 30, 2024
@matejk matejk requested a review from aleks-f July 30, 2024 18:54
@aleks-f aleks-f merged commit 7345bf3 into main Aug 17, 2024
73 checks passed
@aleks-f aleks-f deleted the 4591_simple-file-channel-flush-unified branch August 17, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleks-f aleks-f aleks-f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
1.14
Status: Done
Milestone
Release 1.14.0
Development

Successfully merging this pull request may close these issues.

Performance(time) affected because of PR #4429 in LogFileImpl::writeImpl FLUSH. #4429 #2443 code changes due to this has impacted performance.
2 participants
@matejk @aleks-f