Improve boolean environment variables reading #4632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
880f459 to
5e777ac
Compare
5e777ac to
b4ac7a0
Compare
b4ac7a0 to
1714bab
Compare
aerosol
reviewed
Oct 1, 2024
lib/plausible/helpers/config.ex
Outdated
|
|
||
| _ -> | ||
| raise ArgumentError, | ||
| "Invalid boolean value: #{inspect(var)}. Expected one of: 1, 0, t, f, true, false, y, n, on, off" |
There was a problem hiding this comment.
you could extract those guard clauses and combine here, 'yes' and 'no' are missing
ukutaht
approved these changes
Oct 15, 2024
ruslandoga
added a commit
that referenced
this pull request
Dec 6, 2024
* improve bool env var reading * add yes/no and tests
Closed
ruslandoga
added a commit
that referenced
this pull request
Jan 6, 2025
* improve bool env var reading * add yes/no and tests
ruslandoga
added a commit
that referenced
this pull request
Jan 16, 2025
* improve bool env var reading * add yes/no and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR improves reading of boolean environment variables. This change fixes cryptic error messages like in #4618 (comment) where
1was used to meantrueinSMTP_HOST_SSL_ENABLED=1.Tests
Changelog
Documentation
Dark mode