Skip to content

Fix crash on Adreno 3xx GPU devices (e.g. vivo 1606, vivo 1610, Xiaomi Redmi Note 4G). #6876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 14, 2020
Merged

Fix crash on Adreno 3xx GPU devices (e.g. vivo 1606, vivo 1610, Xiaomi Redmi Note 4G). #6876

merged 4 commits into from
Sep 14, 2020

Conversation

dumganhar
Copy link
Contributor

The sampler array should not be a hardcode value of 16 since it will be larger than what maxRecommendedTextures returns.
maxRecommendedTextures will return 4 if the android version is smaller than 7.

The crash stack is:

09-14 14:41:35.409 14755-14934/? A/libc: Fatal signal 6 (SIGABRT), code -6 in tid 14934 (GLThread 1122)
09-14 14:41:35.519 622-622/? A/DEBUG: *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
09-14 14:41:35.519 622-622/? A/DEBUG: Build fingerprint: 'vivo/1606/1606:6.0.1/MMB29M/compiler01052117:user/release-keys'
09-14 14:41:35.519 622-622/? A/DEBUG: Revision: '0'
09-14 14:41:35.519 622-622/? A/DEBUG: ABI: 'arm'
09-14 14:41:35.519 622-622/? A/DEBUG: pid: 14755, tid: 14934, name: GLThread 1122  >>> com.yy.demo <<<
09-14 14:41:35.519 622-622/? A/DEBUG: signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
09-14 14:41:35.569 622-622/? A/DEBUG: Abort message: '=================================================================
    ==14755==ERROR: AddressSanitizer: SEGV on unknown address 0x000003fc (pc 0xae5c89bc bp 0x9cc6fc00 sp 0x9d091170 T16777215)
    ==14755==The signal is caused by a READ memory access.
    ==14755==Hint: address points to the zero page.
        #0 0xae5c89b8  (/system/vendor/lib/egl/libRBGLESv2_adreno.so+0xb39b8)
        #1 0xae59b83a  (/system/vendor/lib/egl/libRBGLESv2_adreno.so+0x8683a)
        #2 0xae57fd4e  (/system/vendor/lib/egl/libRBGLESv2_
09-14 14:41:35.569 622-622/? A/DEBUG:     r0 00000000  r1 00003a56  r2 00000006  r3 9d092978
09-14 14:41:35.569 622-622/? A/DEBUG:     r4 9d092980  r5 9d092930  r6 00000019  r7 0000010c
09-14 14:41:35.569 622-622/? A/DEBUG:     r8 a32c819c  r9 b3f3f820  sl a149fc48  fp a149fc34
09-14 14:41:35.569 622-622/? A/DEBUG:     ip 00000006  sp a149f198  lr b6c972bd  pc b6c996b8  cpsr 400f0010
09-14 14:41:35.589 622-622/? A/DEBUG: backtrace:
09-14 14:41:35.589 622-622/? A/DEBUG:     #00 pc 000426b8  /system/lib/libc.so (tgkill+12)
09-14 14:41:35.589 622-622/? A/DEBUG:     #01 pc 000402b9  /system/lib/libc.so (pthread_kill+32)
09-14 14:41:35.589 622-622/? A/DEBUG:     #02 pc 0001c6f3  /system/lib/libc.so (raise+10)
09-14 14:41:35.589 622-622/? A/DEBUG:     #03 pc 00019961  /system/lib/libc.so (__libc_android_abort+34)
09-14 14:41:35.589 622-622/? A/DEBUG:     #04 pc 0001751c  /system/lib/libc.so (abort+4)
09-14 14:41:35.589 622-622/? A/DEBUG:     #05 pc 000389e0  /data/app/com.yy.demo-1/lib/arm/libclang_rt.asan-arm-android.so (offset 0x2d000)
09-14 14:41:35.589 622-622/? A/DEBUG:     #06 pc 00037754  /data/app/com.yy.demo-1/lib/arm/libclang_rt.asan-arm-android.so (offset 0x2d000)
09-14 14:41:35.589 622-622/? A/DEBUG:     #07 pc 000a15b8  /data/app/com.yy.demo-1/lib/arm/libclang_rt.asan-arm-android.so (offset 0x2d000)
09-14 14:41:35.589 622-622/? A/DEBUG:     #08 pc 000a1224  /data/app/com.yy.demo-1/lib/arm/libclang_rt.asan-arm-android.so (offset 0x2d000)
09-14 14:41:35.589 622-622/? A/DEBUG:     #09 pc 000a0788  /data/app/com.yy.demo-1/lib/arm/libclang_rt.asan-arm-android.so (offset 0x2d000)
09-14 14:41:35.589 622-622/? A/DEBUG:     #10 pc 0035ab6d  /system/lib/libart.so (_ZN3art12FaultManager11HandleFaultEiP7siginfoPv+508)
09-14 14:41:35.589 622-622/? A/DEBUG:     #11 pc 00017580  /system/lib/libc.so
09-14 14:41:36.919 622-622/? A/DEBUG: Tombstone written to: /data/tombstones/tombstone_00

@dumganhar
Fix crash on Adreno 3xx GPU devices (e.g. vivo 1606, vivo 1610, Xiaom…
380a12d 
…i Redmi Note 4G).

The sampler array should not be a hardcode value of 16 since it will be larger than what maxRecommendedTextures returns.
maxRecommendedTextures will return 4 if the android version is smaller than 7.
@dumganhar dumganhar mentioned this pull request Sep 14, 2020
Merged
4 tasks
themoonrat
themoonrat reviewed Sep 14, 2020
View reviewed changes
@bigtimebuddy bigtimebuddy added this to the v5.4.0 milestone Sep 14, 2020
@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Sep 14, 2020
GoodBoyDigital
GoodBoyDigital approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@bigtimebuddy bigtimebuddy merged commit 97e32e9 into pixijs:dev Sep 14, 2020
@bigtimebuddy
Copy link
Member

Another good one @dumganhar 👍

bigtimebuddy pushed a commit that referenced this pull request Dec 17, 2020
@dumganhar @bigtimebuddy
Fix crash on Adreno 3xx GPU devices (e.g. vivo 1606, vivo 1610, Xiaom…
c19cf1b 
…i Redmi Note 4G) (#6876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShukantPal ShukantPal ShukantPal left review comments

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@themoonrat themoonrat themoonrat approved these changes

@GoodBoyDigital GoodBoyDigital GoodBoyDigital approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dumganhar @bigtimebuddy @themoonrat @GoodBoyDigital @ShukantPal