fix: Store group description in public_info
#1384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `create_or_update_user_group()` sets the group description directly inside the `properties` dict, but only the values of the `public_info` key are exposed via the API. This change stores the description in the correct location so that the UI can display it.
czgu
approved these changes
Dec 8, 2023
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
Currently, `create_or_update_user_group()` sets the group description directly inside the `properties` dict, but only the values of the `public_info` key are exposed via the API. This change stores the description in the correct location so that the UI can display it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
create_or_update_user_group()sets the group description directly inside thepropertiesdict, but only the values of thepublic_infokey are exposed via the API.This change stores the description in the correct location so that the UI can display it.