Skip to content

fix: cast table max upload size to int #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: cast table max upload size to int #1374

merged 1 commit into from
Nov 21, 2023

Conversation

rchandnaeg
Copy link
Contributor

Environment variables are loaded in as strings, which results in the following error for loading QuerybookSettings.TABLE_MAX_UPLOAD_SIZE

querybook_web            | Traceback (most recent call last):
querybook_web            |   File "/opt/querybook/querybook/server/app/datasource.py", line 84, in handler
querybook_web            |     results = fn(**kwargs)
querybook_web            |   File "/opt/querybook/querybook/server/datasources/event_log.py", line 18, in log_frontend_event
querybook_web            |     events = json.loads(flask.request.data)

This fix casts the table max upload size variable to an int before applying it to the flask app config

@czgu czgu merged commit e2efe8e into pinterest:master Nov 21, 2023
@czgu
Copy link
Collaborator

czgu commented Nov 21, 2023

thank you!

aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
@rchandnaeg @aidenprice
fix: cast table max upload size to int (pinterest#1374)
7c4d876
@rchandnaeg rchandnaeg deleted the external/table-max-upload-size-int branch February 22, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgu czgu czgu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchandnaeg @czgu