Skip to content

Revert "fix: Fix DataDoc contents overflow in non-Chrome browsers (#1332)" #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2023
Merged

Revert "fix: Fix DataDoc contents overflow in non-Chrome browsers (#1332)" #1336

merged 1 commit into from
Sep 21, 2023

Conversation

jczhong84
Copy link
Collaborator

This reverts commit 18c86a6.

It caused datadoc with many data cells can't be fully loaded

@baumandm

@jczhong84 jczhong84 merged commit 5d0ed1d into pinterest:master Sep 21, 2023
adamstruck
adamstruck reviewed Sep 25, 2023
View reviewed changes
querybook/webapp/components/DataDoc/DataDoc.scss
@@ -37,8 +37,6 @@
flex: 0 1 var(--max-width);
padding: 36px 8px 36px 16px;

overflow-x: auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting width: 100% fixed this issue in our deployment.

@baumandm
Copy link
Contributor

I was able to resolve the issues with cells not loading by changing DataDocCellWrapper.tsx, adding scrollContainer and removing overflow:

        <ReactLazyLoad
            // The height is just a placeholder
            // we use the minimum height of a cell
            // to estimate
            scrollContainer=".EnvironmentAppRouter-content"
            height={placeholderHeight}
            offset={300}
            placeholder={<Loading height={placeholderHeight} />}
            throttle={500}
        >
            {children}
        </ReactLazyLoad>

aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
@jczhong84 @aidenprice
Revert "fix: Fix DataDoc contents overflow in non-Chrome browsers (pi…
2a17a95 
…nterest#1332)" (pinterest#1336)

This reverts commit 18c86a6.
@jczhong84 jczhong84 deleted the fix/datadoc branch March 6, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgu czgu czgu approved these changes

+1 more reviewer

@adamstruck adamstruck adamstruck left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jczhong84 @baumandm @adamstruck @czgu