[issue#198] No more GUI option for "additional transaction fee" :) #199
Conversation
src/bitcoinrpc.cpp
Outdated
| @@ -448,7 +448,6 @@ static const CRPCCommand vRPCCommands[] = | |||
| { "verifymessage", &verifymessage, false, false }, | |||
| { "getwork", &getwork, true, false }, | |||
| { "listaccounts", &listaccounts, false, false }, | |||
| { "settxfee", &settxfee, false, false }, | |||
There was a problem hiding this comment.
there's really no need to remove that rpc call, just remove it from gui part if you must.
|
will stick to just the gui options 👍 |
|
@belovachap better rewrite history of this pull request. So just do a This will also make it easier to cherry pick in later code rebases. |
99ea18d to
890a070
Compare
|
@backpacker69 @belovachap |
| @@ -17,7 +17,8 @@ QT_TRANSLATE_NOOP("bitcoin-core", "" | |||
| "If the file does not exist, create it with owner-readable-only file " | |||
| "permissions.\n" | |||
| "It is also recommended to set alertnotify so you are notified of problems;\n" | |||
| "for example: alertnotify=echo %%s | mail -s \"Peercoin Alert\" admin@foo.com\n"), | |||
| "for example: alertnotify=echo %%s | mail -s \"Peercoin Alert\" admin@foo." | |||
| "com\n"), | |||
There was a problem hiding this comment.
It possibly is an accidental return.
But it doesn't impact compilation, it's just syntactically different.
Good catch though, will revert this later.
Corrected some changes in pull #199
👋 @peerchemist @hrobeers @backpacker69
This fella #198
I wrote a thing! Pulled back the changes to just remove text and option from the GUI options. Also ran the translation string extraction script and whatever
lupdateis (some sort of QT tool?).Can still send transactions on the testnet... so that's encouraging 🌈