Signature fix 2 #116
Merged
Signature fix 2 #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signature lengths stored on more than 4 bytes are accepted by OpenSSL 64 bits but rejected by OpenSSL 32 bits. The previous fix (9b40cd5) prevented that on the whole signature length but not on the R and S lengths. This patch normalizes all the lengths by parsing and rewriting the whole structure.
|
@rat4 What do you think about this? |
|
I have compiled with this patch and everything seems to run as normal on Linux Mint 64-bit. |
|
Would be great if someone on Windows 32-bit or Linux 32-bit could compile and test. |
|
Looks great! Thanks Mike for the quick fix :) |
|
@glv2 Can you push this to peerunity master as well? Would also be great if you could make another release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to fix the current fork between 32 and 64 bits systems.