Upgrade codec to 2.0 and bitvec to 0.20 (companion) #2343
Conversation
|
(please merge master) |
|
|
||
| polkadot-subsystem = { package = "polkadot-node-subsystem", path = "../../subsystem" } | ||
| polkadot-overseer = { path = "../../overseer" } | ||
| polkadot-primitives = { path = "../../../primitives" } | ||
| polkadot-node-primitives = { path = "../../primitives" } | ||
| bitvec = "0.17.4" | ||
| bitvec = "0.20.1" |
There was a problem hiding this comment.
I wonder whether we only need
bitvec = { version = "0.20.1", default-features = false, features = ["alloc"] }as in other places. otherwise cargo will end up using the default features everywhere.
There was a problem hiding this comment.
I guess those crate are only compiled with std
There was a problem hiding this comment.
You're right that the runtime crates are built with wasm-builder and hence do no suffer from the feature leak in a workspace. This also wasn't introduced by this PR.
However, I think we should not unnecessarily import features we do not use here and just keep it to the bare minimum. We do this for other std crates like provisioner and backing, but not here in av-store.
|
|
||
| polkadot-subsystem = { package = "polkadot-node-subsystem", path = "../../subsystem" } | ||
| polkadot-overseer = { path = "../../overseer" } | ||
| polkadot-primitives = { path = "../../../primitives" } | ||
| polkadot-node-primitives = { path = "../../primitives" } | ||
| bitvec = "0.17.4" | ||
| bitvec = "0.20.1" |
There was a problem hiding this comment.
You're right that the runtime crates are built with wasm-builder and hence do no suffer from the feature leak in a workspace. This also wasn't introduced by this PR.
However, I think we should not unnecessarily import features we do not use here and just keep it to the bare minimum. We do this for other std crates like provisioner and backing, but not here in av-store.
|
Waiting for commit status. |
|
bot merge |
|
Missing process info; check that the PR belongs to a project column. Merge can be attempted if:
|
|
bot merge |
|
Waiting for commit status. |
|
Checks failed; merge aborted. |
|
bot merge |
|
Waiting for commit status. |
|
Checks failed; merge aborted. |
For information here is the bitvec changelog: https://github.com/bitvecto-rs/bitvec/blob/develop/CHANGELOG.md
and the codec changelog: https://github.com/paritytech/parity-scale-codec/blob/master/CHANGELOG.md
companion for paritytech/substrate#7994