Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

configuration: Rename validation_upgrade_{frequency -> cooldown} #4635

Merged
merged 1 commit into from
Dec 30, 2021
Merged

configuration: Rename validation_upgrade_{frequency -> cooldown} #4635

merged 1 commit into from
Dec 30, 2021

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Dec 29, 2021 •
edited
Loading

This just renames a member of HostConfiguration from
validation_upgrade_frequency to -//-_cooldown.

As was already pointed out in #4460 the existing name is a misnomer, the
member actually represents a minimum time period between upgrades, which
is neatly expressed by a word cooldown.

I've been planning this rename already for some time and the term is
already used in paras module:

polkadot/runtime/parachains/src/paras.rs

Lines 1568 to 1574 in 0f1a671

let next_possible_upgrade_at = relay_parent_number + cfg.validation_upgrade_frequency;
<Self as Store>::UpgradeCooldowns::mutate(|upgrade_cooldowns| {
let insert_idx = upgrade_cooldowns
.binary_search_by_key(&next_possible_upgrade_at, |&(_, b)| b)
.unwrap_or_else(|idx| idx);
upgrade_cooldowns.insert(insert_idx, (id, next_possible_upgrade_at));
});

cumulus companion: paritytech/cumulus#880

@pepyakin
Copy link
Contributor Author

pepyakin commented Dec 29, 2021 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Dec 29, 2021
@pepyakin pepyakin added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Dec 29, 2021
@pepyakin
configuration: Rename validation_upgrade_{frequency -> cooldown}
7552ad1 
This just renames a member of `HostConfiguration` from
validation_upgrade_frequency to -//-_cooldown.

As was already pointed out in #4460 the existing name is a misnomer, the
member actually represents a minimum time period between upgrades, which
is neatly expressed by a word cooldown.

I've been planning this rename already for some time and the term is
already used in paras module:

https://github.com/paritytech/polkadot/blob/0f1a67114ad4c849223f87fa48c3dd3d9743832c/runtime/parachains/src/paras.rs#L1568-L1574
@pepyakin pepyakin mentioned this pull request Dec 29, 2021
Merged
@pepyakin pepyakin force-pushed the pep-validation-upgrade-cooldown branch from abb8a60 to 7552ad1 Compare December 29, 2021 14:58
@pepyakin pepyakin mentioned this pull request Dec 29, 2021
Merged
@pepyakin pepyakin requested a review from bkchr December 29, 2021 16:22
@pepyakin
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 5bb1d3a into master Dec 30, 2021
@paritytech-processbot paritytech-processbot bot deleted the pep-validation-upgrade-cooldown branch December 30, 2021 20:24
ordian pushed a commit that referenced this pull request Jan 3, 2022
Merge branch 'master' into ao-lower-collator-inactivity-period
048e7c3 
* master:
  Set CurrentCodeHash before running some dispatchable benchmarks (#4645)
  paras: split tests (#4636)
  Bump quote from 1.0.10 to 1.0.14 (#4632)
  Bump pin-project from 1.0.8 to 1.0.9 (#4606)
  chore: fix copy&paste and tidy comments (#4646)
  derive Copy and Clone for Upgrade signals (#4637) (#4647)
  paras: fix upgrade restriction signal (#4603)
  configuration: Rename validation_upgrade_{frequency -> cooldown} (#4635)
  Bump lru from 0.7.1 to 0.7.2 (#4633)
  paras: add governance control dispatchables (#4575)
drahnr pushed a commit that referenced this pull request Jan 4, 2022
@pepyakin @drahnr
configuration: Rename validation_upgrade_{frequency -> cooldown} (#4635)
4f0f201 
This just renames a member of `HostConfiguration` from
validation_upgrade_frequency to -//-_cooldown.

As was already pointed out in #4460 the existing name is a misnomer, the
member actually represents a minimum time period between upgrades, which
is neatly expressed by a word cooldown.

I've been planning this rename already for some time and the term is
already used in paras module:

https://github.com/paritytech/polkadot/blob/0f1a67114ad4c849223f87fa48c3dd3d9743832c/runtime/parachains/src/paras.rs#L1568-L1574
Wizdave97 pushed a commit to ComposableFi/polkadot that referenced this pull request Feb 3, 2022
@pepyakin @Wizdave97
configuration: Rename validation_upgrade_{frequency -> cooldown} (par…
e560678 
…itytech#4635)

This just renames a member of `HostConfiguration` from
validation_upgrade_frequency to -//-_cooldown.

As was already pointed out in paritytech#4460 the existing name is a misnomer, the
member actually represents a minimum time period between upgrades, which
is neatly expressed by a word cooldown.

I've been planning this rename already for some time and the term is
already used in paras module:

https://github.com/paritytech/polkadot/blob/0f1a67114ad4c849223f87fa48c3dd3d9743832c/runtime/parachains/src/paras.rs#L1568-L1574
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr Awaiting requested review from bkchr

1 more reviewer

@eskimor eskimor eskimor approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pepyakin @eskimor