Async Iterable Response #5659
Merged
Async Iterable Response #5659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is correct either, since Flask views can't return async iterables. |
|
I guess I'll merge it, the type is still checked at runtime. In Quart returning a |
CoolCat467
added a commit
to CoolCat467/Scanner-Server
that referenced
this pull request
Mar 31, 2025
pallets/flask#5659 just got merged fixing the typing issues, but they haven't made a release yet so use the repo directly until that happens
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, we fix the typing for what is allowed to be used as a response type, allowing responses to be
AsyncIterable[str]orAsyncIterable[bytes].Flask sans-io is used by Quart
Through a huge chain of things, this pull request fixes #5322, because pallets/quart#341 doesn't actually fix the root issue unfortunately.