Skip to content

Conversation

jeanschmidt
Copy link
Contributor

@jeanschmidt jeanschmidt commented Nov 25, 2022

This is forward fix for : #86786
Which generates following error when compiled with -Werror:

CUDAMallocAsyncAllocator.cpp:433:8: error: 'initialized' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  bool initialized() {

See declaration of CUDAAllocator:
https://github.com/pytorch/pytorch/blob/master/c10/cuda/CUDACachingAllocator.h#L186

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 25, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89687

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 32f72d7:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 25, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jeanschmidt / name: Jean Schmidt (32f72d7)

@jeanschmidt jeanschmidt added the topic: not user facing topic category label Nov 25, 2022
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeanschmidt jeanschmidt merged commit d089fbd into master Nov 28, 2022
@jeanschmidt jeanschmidt deleted the jeanschmidt/suppress_werror_override_cudamalloc branch November 28, 2022 14:16
@malfet
Copy link
Contributor

malfet commented Nov 28, 2022

Merge bot should have been used to commit the change

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants