Skip to content

docs: conv2d padding attribute- add int option #85004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: conv2d padding attribute- add int option #85004

wants to merge 1 commit into from

Conversation

YoniChechik
Copy link
Contributor

@YoniChechik YoniChechik commented Sep 14, 2022 •
edited
Loading

padding: int already exists but isn't mentioned in the genereted docs

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 14, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85004

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6b45d48:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@dagitses dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 16, 2022
albanD
albanD approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@albanD
Copy link
Collaborator

albanD commented Sep 22, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again.

Details for Dev Infra team Raised by workflow job

@albanD
Copy link
Collaborator

albanD commented Sep 22, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased patch-1 onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout patch-1 && git pull --rebase)

@facebook-github-bot
Copy link
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 4, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: YoniChechik / name: Yoni Chechik (61488f919776b73273d960b97578cd1f8ed00307)

@kit1980
Copy link
Contributor

kit1980 commented Nov 18, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@YoniChechik @pytorchmergebot
docs: conv2d padding attribute- add int option
6b45d48 
`padding: int` already exists but isn't mentioned in the genereted docs
@pytorchmergebot
Copy link
Collaborator

Successfully rebased patch-1 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout patch-1 && git pull --rebase)

@kit1980
Copy link
Contributor

kit1980 commented Nov 18, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 18, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@YoniChechik YoniChechik deleted the patch-1 branch November 20, 2022 08:03
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@YoniChechik @kulinseth
docs: conv2d padding attribute- add int option (pytorch#85004)
3882197 
`padding: int` already exists but isn't mentioned in the genereted docs

Pull Request resolved: pytorch#85004
Approved by: https://github.com/albanD, https://github.com/kit1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit1980 kit1980 kit1980 approved these changes

@albanD albanD albanD approved these changes

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@YoniChechik @albanD @pytorchmergebot @facebook-github-bot @kit1980 @dagitses @pytorchbot