Skip to content

Conversation

keehyuna
Copy link
Collaborator

@keehyuna keehyuna commented Jun 5, 2024

Description

Add dynamic shape test for sub and supports_dynamic_shapes=True flag

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 5, 2024
@github-actions github-actions bot requested a review from narendasan June 5, 2024 11:29
@keehyuna keehyuna requested review from peri044, chohk88 and zewenli98 June 5, 2024 11:30
@keehyuna keehyuna self-assigned this Jun 5, 2024
@keehyuna keehyuna marked this pull request as ready for review June 5, 2024 11:31
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 7182f50 into pytorch:main Jun 7, 2024
@keehyuna keehyuna deleted the sub_dynamic_shape branch August 19, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants