Refactor nox requirements to use requirements files (#601) #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
approved these changes
Nov 7, 2022
|
Thanks for filling this @strokirk! This looks good to me, assuming CI is happy with this. |
uranusjr
reviewed
Nov 7, 2022
| @@ -0,0 +1,4 @@ | |||
| coverage[toml]>=5.0.0 | |||
| pip>=9.0.2 | |||
There was a problem hiding this comment.
Not really related to this PR, but is this line still relevant now that we require Python 3.7+?
There was a problem hiding this comment.
I don't think so, but technically you don't have to have pip installed in an environment either, so I don't think it's hurting anything by being explicit.
brettcannon
approved these changes
Nov 8, 2022
|
Thanks! |
KOLANICH
pushed a commit
to KOLANICH-libs/packaging
that referenced
this pull request
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an active discussion about alternatives in discuss.python.org, but hopefully this will help with the immediate need. 🙂
First patch, so please say if it's too early in the discussion to make a PR, or if another approach would be better!