Skip to content

Add MISSING sentinel #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 25, 2025
Merged

Add MISSING sentinel #1711

merged 9 commits into from
Jul 25, 2025

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented May 16, 2025

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 16, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1711 will not alter performance

Comparing unset-sentinel (471da62) with main (b1c9f21)

Summary

✅ 157 untouched benchmarks

@Viicos Viicos mentioned this pull request May 16, 2025
Merged
davidhewitt
davidhewitt reviewed May 17, 2025
View reviewed changes
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me 👍

@Viicos Viicos force-pushed the unset-sentinel branch 2 times, most recently from 8310c5f to bcee7bd Compare July 1, 2025 13:22
@Viicos Viicos force-pushed the unset-sentinel branch 3 times, most recently from b9ba89c to d260499 Compare July 2, 2025 11:00
@Viicos Viicos force-pushed the unset-sentinel branch 3 times, most recently from af37618 to c440f31 Compare July 25, 2025 14:01
@Viicos Viicos changed the title Add UNSET sentinel Add MISSING sentinel Jul 25, 2025
@Viicos Viicos marked this pull request as ready for review July 25, 2025 16:13
@Viicos Viicos merged commit b787c41 into main Jul 25, 2025
30 of 38 checks passed
@Viicos Viicos deleted the unset-sentinel branch July 25, 2025 16:18
@renovate renovate bot mentioned this pull request Aug 22, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Viicos @davidhewitt