-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add experimental MISSING
sentinel
#11883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+276
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
I could imagine users might want custom sentinels too, should there be a generic "sentinel" schema? |
1 task
Deploying pydantic-docs with
|
Latest commit: |
9ed9218
|
Status: | ✅ Deploy successful! |
Preview URL: | https://b51576eb.pydantic-docs.pages.dev |
Branch Preview URL: | https://unset-sentinel.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #11883 will not alter performanceComparing Summary
|
DouweM
approved these changes
Jul 25, 2025
This was referenced Jul 26, 2025
This was referenced Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Requires pydantic/pydantic-core#1711.
Fixes #5326.
Fixes #6928.
Fixes #7712.
Fixes #8394.
Fixes #9057.
Fixes #11705.
Fixes #11843.
Example:
Things to consider:
Sentinel name:Went withUNSET
seems to be the best fit (and matchesmsgspec
), but will be confusing as we already have a concept of unset fields (tracked in__pydantic_fields_set__
). These unset fields can already be excluded by specifyingexclude_unset=True
during serialization. If users explicitly setexclude_unset=False
but theUNSET
sentinel is still excluded, this will be confusing. One alternative could beMISSING
: it also makes it a little bit clearer that the expected behavior is to have fields set toMISSING
excluded from the output.MISSING
.pydantic-core
, but we need to expose it from theexperimental
module as we rely on the draft PEP 661.Should we create a new core schema for theUNSET
sentinel? I'm currently using a'literal'
schema, but not ideal for a couple reasons:The core validator uses equality to validate literal values, but sentinels should be compared using identity.If we happen to implement an optimization where we mergeWent with a new core schema type.'literal'
schemas together (e.g.Literal[1] | UNSET
->Literal[1, UNSET]
), we would need to account for this in the JSON Schema generation logic).