Skip to content

decrease minimum version of imgui-bundle #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

hmaarrfk
Copy link
Contributor

@Korijn Korijn marked this pull request as ready for review January 27, 2025 06:01
@Korijn Korijn self-requested a review as a code owner January 27, 2025 06:01
@Korijn Korijn marked this pull request as draft January 27, 2025 06:01
@Korijn
Copy link
Collaborator

Korijn commented Jan 27, 2025

I prefer this change over #956, as it restores consistency with wgpu-py. I also pushed a commit to ensure we test the examples on the minimum supported python version going forward.

@Korijn Korijn marked this pull request as ready for review January 27, 2025 07:32
@tlambert03
Copy link
Contributor

Yep, definitely better

@Korijn Korijn merged commit fcd27d5 into pygfx:main Jan 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants