Skip to content

add python min to imgui pin #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

add python min to imgui pin #956

wants to merge 2 commits into from

Conversation

tlambert03
Copy link
Contributor

This pins imgui-bundle>=1.6.0; python_version >= '3.10' (adding the min python version) in pyproject.

uv sync is a pretty great way to simply get up and running, and if you try to run uv sync --extra dev here, you get an error:

Creating virtual environment at: .venv
  × No solution found when resolving dependencies for split (python_full_version == '3.9.*'):
  ╰─▶ Because the requested Python version (>=3.9) does not satisfy Python>=3.10 and imgui-bundle>=1.6.0 depends on Python>=3.10, we can conclude
      that imgui-bundle>=1.6.0 cannot be used.
      And because only the following versions of imgui-bundle are available:
          imgui-bundle<=1.6.0
          imgui-bundle==1.6.1
          imgui-bundle==1.6.2
      we can conclude that imgui-bundle>=1.6.0 cannot be used.
      And because pygfx[dev] depends on imgui-bundle>=1.6.0 and your project requires pygfx[dev], we can conclude that your project's requirements
      are unsatisfiable.

      hint: The `requires-python` value (>=3.9) includes Python versions that are not supported by your dependencies (e.g., imgui-bundle>=1.6.0
      only supports >=3.10). Consider using a more restrictive `requires-python` value (like >=3.10).

It does actually make sense... imgui-bundle itself would never work in 3.9, so might as well? 🤷‍♂️

@tlambert03 tlambert03 requested a review from Korijn as a code owner January 26, 2025 23:17
@hmaarrfk
Copy link
Contributor

Your setting yourself up for failure if you start to install all of every packages example dependencies.

But honestly, why not revert #890 (comment)

I fixed the problem in wgpu to ensure that everything was good even with the older version

@tlambert03
Copy link
Contributor Author

Your setting yourself up for failure

i'm plenty capable of dealing with issues as they arise, thanks. environments are easily disposable and i'm well aware that i can always install the bare minimum should anything be strange. In any case, it's just pip install -e .[dev], which is pretty standard practice no?

But honestly, why not revert #890 (comment)

that's fine too. i just opened this to let you know you had an unsatisfiable dep. do with it what you like. including close

@ivoflipse
Copy link
Contributor

Perhaps the examples should leverage PEP 723 so you an easily run them using uv
https://docs.astral.sh/uv/guides/scripts/

@hmaarrfk hmaarrfk mentioned this pull request Jan 27, 2025
Merged
@hmaarrfk
Copy link
Contributor

i'm plenty capable of dealing with issues as they arise, thanks

I didn't mean anything as an insult.

Sorry if it came out that way.

See: #958 and pygfx/wgpu-py#649

@Korijn
Copy link
Collaborator

Korijn commented Jan 27, 2025

that's fine too. i just opened this to let you know you had an unsatisfiable dep. do with it what you like. including close

Much appreciated, that kind of thing is not supposed to go unnoticed. I will adjust CI to cover the minimum supported python version, that should already improve our capacity to detect such problems going forward.

Perhaps the examples should leverage PEP 723 so you an easily run them using uv
https://docs.astral.sh/uv/guides/scripts

I have to read up on that, thanks for the reference!

@Korijn Korijn closed this in #958 Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Korijn Korijn Awaiting requested review from Korijn Korijn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tlambert03 @hmaarrfk @ivoflipse @Korijn