Copying fixes #88
Merged
Copying fixes #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--foreground just hangs the mprocs process
not add newlines if row is wrapped
pvolok
reviewed
May 23, 2023
| @@ -30,7 +30,7 @@ fn detect_copy_provider() -> Provider { | |||
| // Wayland | |||
| if std::env::var("WAYLAND_DISPLAY").is_ok() { | |||
| if let Some(provider) = | |||
| check_prog("wl-copy", &["--foreground", "--type", "text/plain"]) | |||
There was a problem hiding this comment.
Thank you for the PR! What was the reason for removing this? If I'm not mistaken, there was a problem without that argument. But I can't remember for sure.
There was a problem hiding this comment.
with --foreground, mprocs process just hangs forever after copying (doesn't respond to user input).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #79 fedimint/fedimint#2300