-
-
Notifications
You must be signed in to change notification settings - Fork 133
fix: source _pure_prompt_new_line event handler instead of relying on autoloading #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test are silently failing
|
Seems to do the trick! There is a space now after the output of a command Although it doesn't have space above the initial prompt, seems to be fine after |
I'm using Tmux which might differ from what you have, could you share a screenshot? |
Any update? |
… autoloading From the doc: https://fishshell.com/docs/current/language.html#event > Please note that event handlers only become active when a function is loaded, > which means you need to otherwise source or execute a function instead of > relying on autoloading. fix #356
I'm rebasing and merging as the initial issue was fixed. |
215acb1
to
159e0b6
Compare
This broke on NixOS for me. Reported in nixpkgs: NixOS/nixpkgs#408917 (comment) |
…ry too related: fix: source _pure_prompt_new_line event handler instead of relying on autoloading #357
related: fixes #356
From the doc: https://fishshell.com/docs/current/language.html#event
TODO
How to test pre-release?
fisher install pure-fish/pure@fix/no-line-spacing-between-prompts-356 # branch name
Specs
Documentation
Event handlers aren't autoloaded, so we need to force loading of the
_pure_prompt_new_line
handler in the init process.Acceptance Checks
conf.d/pure.fish
for:tests/feature_name.test.fish
;