CloudFormation v2 Engine: Base Support for Fn::GetAZs #12699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results - Alternative Providers983 tests 564 ✅ 22m 33s ⏱️ Results for commit 82ca923. ♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro 2 files 2 suites 22m 0s ⏱️ Results for commit 82ca923. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 22m 29s ⏱️ Results for commit 82ca923. ♻️ This comment has been updated with latest results. |
simonrw
approved these changes
Jun 3, 2025
| @@ -109,7 +109,6 @@ def test_cfn_with_multiple_route_tables(deploy_cfn_template, aws_client): | |||
| assert len(resp["RouteTables"]) == 4 | |||
|
|
|||
|
|
|||
| @pytest.mark.skip(reason="CFNV2:Fn::Select, CFNV2:Fn::GatAZs") | |||
| @@ -165,7 +164,6 @@ def test_dhcp_options(aws_client, deploy_cfn_template, snapshot): | |||
| snapshot.match("description", response["DhcpOptions"][0]) | |||
|
|
|||
|
|
|||
| @pytest.mark.skip(reason="CFNV2:Fn::Select, CFNV2:Fn::GatAZs") | |||
| @@ -197,7 +197,6 @@ def test_cidr_function(self, deploy_cfn_template): | |||
|
|
|||
| assert deployed.outputs["Address"] == "10.0.0.0/24" | |||
|
|
|||
| @pytest.mark.skip(reason="CFNV2:Fn::GetAZs") | |||
| account_id = self._change_set.account_id | ||
| ec2_client = connect_to(aws_access_key_id=account_id, region_name=region).ec2 | ||
| try: | ||
| get_availability_zones_result: DescribeAvailabilityZonesResult = ( |
There was a problem hiding this comment.
nit
Suggested change
| get_availability_zones_result: DescribeAvailabilityZonesResult = ( | |
| describe_availability_zones_result: DescribeAvailabilityZonesResult = ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The introduction of the CloudFormation v2 engine laid the foundation for a redesigned engine capable of accurately determining update requirements between CloudFormation deployments, while also enabling parallel execution during updates. However, the current implementation offers no support for
Fn::GetAZs.Changes
Fn::GetAZs