Skip to content

Step Functions: Add Supported Integrations For Glue #12248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

Step Functions: Add Supported Integrations For Glue #12248

merged 1 commit into from
Feb 10, 2025

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Feb 10, 2025

Motivation

Recent changes in the Step Functions interpreter limited the execution of service integration to the set of the officially supported ones #12223. This exposed the lack of such checks for the Glue optimized service integration. These changes add such specification for Glue.

Changes

  • Add the list of supported api parameter bindings for Glue's optimized service integration.

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Feb 10, 2025
@MEPalma MEPalma added this to the 4.2 milestone Feb 10, 2025
@MEPalma MEPalma self-assigned this Feb 10, 2025
@MEPalma MEPalma requested review from bentsku and removed request for joe4dev and gregfurman February 10, 2025 22:11
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   33m 46s ⏱️ - 1h 18m 50s
1 435 tests  - 2 662  1 363 ✅  - 2 418  72 💤  - 244  0 ❌ ±0 
1 437 runs   - 2 662  1 363 ✅  - 2 418  74 💤  - 244  0 ❌ ±0 

Results for commit 7b7be17. ± Comparison against base commit dfe3575.

This pull request removes 2662 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

bentsku
bentsku approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for jumping on this and fixing the pipeline 🚀
I'll merge the PR to unblock the pipeline if that's okay!

Edit: sorry @MEPalma I just saw you reacted, hope that's alright 😅

@bentsku bentsku merged commit a43bd8f into master Feb 10, 2025
36 checks passed
@bentsku bentsku deleted the MEP-SFN-add_glue_supported_api_param_bindings branch February 10, 2025 23:29
@MEPalma
Copy link
Contributor Author

MEPalma commented Feb 11, 2025

Absolutely @bentsku!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsku bentsku bentsku approved these changes

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@MEPalma @bentsku