Skip to content

Add info about how to enable type hints for testing to dev setup guide #12211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

Add info about how to enable type hints for testing to dev setup guide #12211

merged 1 commit into from
Jan 31, 2025

Conversation

tiurin
Copy link
Contributor

@tiurin tiurin commented Jan 30, 2025

Motivation

Update dev setup guide with info about type hinting enablement.

Changes

Optional note in installing python dependencies step.

@tiurin tiurin added area: documentation Issues related to LocalStack documentation semver: patch Non-breaking changes which can be included in patch releases labels Jan 30, 2025
@tiurin tiurin requested a review from bentsku January 30, 2025 19:02
@tiurin tiurin force-pushed the add-type-hints-enablement-to-dev-setup-guide branch from fcb58cb to 5e4ceb5 Compare January 30, 2025 19:55
bentsku
bentsku approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for adding the note! I'm not sure I fully get the pipeline failure 🤔 but it's somewhat not relevant anyway

@tiurin tiurin force-pushed the add-type-hints-enablement-to-dev-setup-guide branch from 5e4ceb5 to b9f2caf Compare January 31, 2025 08:34
@tiurin
Copy link
Contributor Author

tiurin commented Jan 31, 2025

I'm not sure I fully get the pipeline failure 🤔
@bentsku I think CircleCI fails because no tests were selected in test-selection step - then on integration tests step a index out of bounds happens in circleci's own test selector:

panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
github.com/circleci/build-agent/cmd/tests.testSelector({{0x0, 0x0}, 0x0, 0x4, {0xffffc0d7a026, 0x7}, {{0x0, 0x0}}, {0x400004ca10, 0x66}, ...}, ...)
        /mnt/ramdisk/circleci/project/cmd/tests/split.go:341 +0x6c0

I'll merge this one as is, code is not affected here.

@tiurin tiurin merged commit 96c4ae5 into master Jan 31, 2025
17 of 19 checks passed
@tiurin tiurin deleted the add-type-hints-enablement-to-dev-setup-guide branch January 31, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsku bentsku bentsku approved these changes

@thrau thrau Awaiting requested review from thrau

@HarshCasper HarshCasper Awaiting requested review from HarshCasper

Assignees
No one assigned
Labels
area: documentation Issues related to LocalStack documentation semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiurin @bentsku