Skip to content

[FIRRTL][firtool] Enable advanced layer sink by default #8683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2025
Merged

[FIRRTL][firtool] Enable advanced layer sink by default #8683

merged 3 commits into from
Jul 11, 2025

Conversation

rwy7
Copy link
Contributor

@rwy7 rwy7 commented Jul 10, 2025 •
edited
Loading

changes:

  • remove firtool's --advanced-layer-sink option, advanced layer sink is now the default
  • disable layer sink if --disable-opt is true
  • remove the old layer-sink pass, and rename advanced-layer-sink to just layer-sink

@rwy7 rwy7 requested review from darthscsi and seldridge as code owners July 10, 2025 15:10
@rwy7 rwy7 changed the title Advanced layer sink default [FIRRTL][firtool] Enable advanced layer sink by default Jul 10, 2025
@rwy7 rwy7 added the FIRRTL Involving the `firrtl` dialect label Jul 10, 2025
@rwy7 rwy7 mentioned this pull request Jul 10, 2025
Closed
seldridge
seldridge reviewed Jul 10, 2025
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR accidentally dropped the advanced-layer-sink.mlir tests. I assume this should've been renamed/moved to layer-sink.mlir?

@rwy7 rwy7 force-pushed the advanced-layer-sink-default branch from c0b4b83 to ba68023 Compare July 10, 2025 19:44
@rwy7
Copy link
Contributor Author

rwy7 commented Jul 10, 2025

Whoops! Thanks, fixed

seldridge
seldridge approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(Naive) layer sink is dead. Long live (advanced) layer sink.

rwy7 added 3 commits July 10, 2025 18:06
@rwy7
[firtool] Remove advanced layer sink option
fc1c621 
Advanced layer sink is now the only "layer sinking" pass that can run, it is no
longer possible to run the original layer sink pass. This commit also disables
layer sinking when optimizations are disabled.
@rwy7
[FIRRTL] Remove the LayerSink pass
7c32973
@rwy7
[FIRRTL] Rename advanced-layer-sink to layer-sink
9916a8b
@rwy7 rwy7 force-pushed the advanced-layer-sink-default branch from ba68023 to 9916a8b Compare July 10, 2025 22:21
@seldridge seldridge merged commit 323a112 into llvm:main Jul 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

Assignees
No one assigned
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwy7 @seldridge