[circt-verilog] Add MapArithToComb pass to pipeline #8649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the MapArithToComb pass to the circt-verilog pipeline. The canonicalizers in the CF dialect produce `arith.select` and `arith.constant` operations, but we would like the circt-verilog pipeline to produce pure HW/Comb/Seq output where possible. In the future we might want to move the pass from `Transforms` to `Conversions`.
uenoku
approved these changes
Jul 3, 2025
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
Add the MapArithToComb pass to the circt-verilog pipeline. The canonicalizers in the CF dialect produce `arith.select` and `arith.constant` operations, but we would like the circt-verilog pipeline to produce pure HW/Comb/Seq output where possible. In the future we might want to move the pass from `Transforms` to `Conversions`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the MapArithToComb pass to the circt-verilog pipeline. The canonicalizers in the CF dialect produce
arith.selectandarith.constantoperations, but we would like the circt-verilog pipeline to produce pure HW/Comb/Seq output where possible.In the future we might want to move the pass from
TransformstoConversions.