Skip to content

Conversation

maerhart
Copy link
Member

@maerhart maerhart commented Jul 2, 2025

This interface provides information necessary for additional static verification of the validate op and about how validate ops can be lowered for the types implementing this interface.

Two of the interface methods implemented by the integer register type are not yet tested, but will be in two future PRs that add passes making use of them (splitting it up in 3 PRs for easier reviewing).

This interface provides information necessary for additional static verification of the validate op and about how validate ops can be lowered for the types implementing this interface.
@maerhart maerhart added the RTG Involving the `rtg` dialect label Jul 2, 2025
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Fabian Schuiki <fabian@schuiki.ch>
@maerhart maerhart merged commit f2e5637 into main Jul 3, 2025
5 checks passed
@maerhart maerhart deleted the maerhart-rtg-validate-interface branch July 3, 2025 10:24
TaoBi22 pushed a commit to TaoBi22/circt that referenced this pull request Jul 17, 2025
Co-authored-by: Fabian Schuiki <fabian@schuiki.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RTG Involving the `rtg` dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants