[Support] Add concatPath method to InstancePathCache #8627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new method to InstancePathCache that concatenates two instance paths. This complements the existing prependInstance and appendInstance methods, providing a more complete API for manipulating instance paths.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a concatPath method to InstancePathCache to enable concatenating two instance paths, complementing the existing prepend and append methods.
- Renames and extends the unit test to validate concatPath functionality.
- Implements concatPath in the source and declares it in the header.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| unittests/Dialect/HW/InstancePathTest.cpp | Updated test name and added validation for concatPath |
| lib/Support/InstanceGraph.cpp | Added the concatPath implementation |
| include/circt/Support/InstanceGraph.h | Declared the new concatPath API |
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
Add a new method to InstancePathCache that concatenates two instance paths. This complements the existing prependInstance and appendInstance methods, providing a more complete API for manipulating instance paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new method to InstancePathCache that concatenates two instance paths. This complements the existing prependInstance and appendInstance methods, providing a more complete API for manipulating instance paths.