[PyCDE] Support for importing Kanagawa #8616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for importing Kanagawa IR into PyCDE and improves the overall pass management and proxy caching in the system.
- Added a new test file for Kanagawa IR import and lowering.
- Updated the System and _OpCache functionality to change type hints and weak reference handling.
- Revised the imported module creation and pass-phase execution logic.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontends/PyCDE/test/test_kanagawa.py | Adds a test case for Kanagawa IR import and verifies lowering. |
| frontends/PyCDE/src/pycde/system.py | Updates type hints, refactors pass-phase execution, and weakens proxy usage. |
| frontends/PyCDE/src/pycde/module.py | Adjusts the imported module creation to guard against misuse. |
| frontends/PyCDE/src/pycde/common.py | Updates slots to support weak references. |
This PR adds support for importing Kanagawa IR into PyCDE and improves the overall pass management and proxy caching in the system. - Added a new test file for Kanagawa IR import and lowering. - Updated the System and _OpCache functionality to change type hints and weak reference handling. - Revised the imported module creation and pass-phase execution logic.
0b94cbb to
3f4fbef
Compare
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
This PR adds support for importing Kanagawa IR into PyCDE and improves the overall pass management and proxy caching in the system. - Added a new test file for Kanagawa IR import and lowering. - Updated the System and _OpCache functionality to change type hints and weak reference handling. - Revised the imported module creation and pass-phase execution logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for importing Kanagawa IR into PyCDE and improves the overall pass management and proxy caching in the system.