[FIRRTL] LowerLayers: do not emit duplicate bindfile includes #8521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
approved these changes
May 30, 2025
When emitting bindfiles for a module, that bindfile will include the bindfiles of any module instantiated directly under it. If a module is instantiated multiple times, we'll emit duplicate include statements. This PR modifies the bindfile creation code to avoid emitting duplicate include statements.
9d20356 to
e7935a0
Compare
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
) When emitting bindfiles for a module, that bindfile will include the bindfiles of any module instantiated directly under it. If a module is instantiated multiple times, we'll emit duplicate include statements. This PR modifies the bindfile creation code to avoid emitting duplicate include statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When emitting bindfiles for a module, that bindfile will include the bindfiles of any module instantiated directly under it.
If a module is instantiated multiple times, we'll emit duplicate include statements. This PR modifies the bindfile creation code to avoid emitting duplicate include statements.
Fixes: #8519