[ESI] Move to somewhat more standard asm format #8482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
teqdruid
commented
May 14, 2025
- Spell out the type names
- Use generated declarative parsers
- Spell out the type names - Use generated declarative parsers
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the ASM format for ESI operations by spelling out type names and transitioning to generated declarative parsers. Key changes include updating buffer and stage operations to use full type signatures, revising CHECK comments accordingly, and removing custom parse/print routines in favor of auto‐generated ones.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/Dialect/ESI/lowering.mlir | Updates type signatures on buffer and stage ops; adjusts CHECKs. |
| test/Dialect/ESI/connectivity.mlir | Similar type signature changes applied to buffer ops and CHECKs. |
| test/Conversion/DCToHW/basic.mlir | Updates CHECK lines to reflect new channel types. |
| lib/Dialect/ESI/ESIOps.cpp | Removes custom parsing/printing in favor of declarative parsers; adds additional verification in verify() functions. |
| include/circt/Dialect/ESI/ESIChannels.td | Introduces declarative assemblyFormat patterns and verifier flags. |
| frontends/PyCDE/test/test_esi*.py | Updates CHECK patterns to use full type names with channel conversions. |
Comments suppressed due to low confidence (2)
test/Dialect/ESI/lowering.mlir:34
- The name 'Reciever' appears to be misspelled. Please consider renaming it to 'Receiver' for clarity and consistency.
hw.instance "recv2" @Reciever (a: %bufferedChan2: !esi.channel<i4>, clk: %clk: !seq.clock) -> ()
test/Dialect/ESI/connectivity.mlir:31
- The identifier '@reciever' seems to be misspelled. It is recommended to use '@receiver' for correct spelling.
hw.instance "recv" @Reciever (a: %bufferedChan: !esi.channel<i1>) -> ()
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
- Spell out the type names - Use generated declarative parsers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.