[FIRRTL] Don't strip layers in LowerXMR #8459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that LowerLayers is moved _after_ LowerXMR, there is no need for LowerXMR to be stripping enabled layers from modules. This fixes a bug where LowerXMR would only strip layers from modules, but not instances. Add a test to lock in the fix. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
rwy7
approved these changes
May 1, 2025
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
Now that LowerLayers is moved _after_ LowerXMR, there is no need for LowerXMR to be stripping enabled layers from modules. This fixes a bug where LowerXMR would only strip layers from modules, but not instances. Add a test to lock in the fix. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that LowerLayers is moved after LowerXMR, there is no need for
LowerXMR to be stripping enabled layers from modules.
This fixes a bug where LowerXMR would only strip layers from modules, but
not instances. Add a test to lock in the fix.
Signed-off-by: Schuyler Eldridge schuyler.eldridge@sifive.com