[Moore] Adding moore.string_cmp Op
#8447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
approved these changes
Apr 30, 2025
|
Thanks a lot @AnnuCode! Going to land this now 👍 |
|
Thank you, @fabianschuiki! 🙂 |
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
Add a new op to handle operations involving `!moore.string` operands per the rules mentioned in IEEE 1800-2012 table 6-9 "String operators".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new Op to handle operations involving
!moore.stringoperands per the rules mentioned in IEEE Std 1800-2012 (page 108).With the proposed code changes, when one operand is of
!moore.stringtype and the other is a string literal, the string literal gets implicitly converted to!moore.stringtype for the comparison. Thus, all the scenarios are covered:!moore.stringtype!moore.stringtype, and the other is a string literal