[RTG] Add tuple operations #8370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4747ca8 to
0d1e07d
Compare
rwy7
reviewed
Apr 16, 2025
| SmallVectorImpl<Type> &inferredReturnTypes) { | ||
| if (operands.empty()) { | ||
| if (loc) | ||
| return mlir::emitError(*loc) << "empty tuples not allowed"; |
There was a problem hiding this comment.
What's the reason for disallowing empty tuples?
There was a problem hiding this comment.
The only reason is that the builtin tuple type does not support an empty list of element types. I could add a new RTG tuple type and allow this. My thought was that I can generalize this when we need it, but I'm also happy to add it right away if you prefer.
youngar
approved these changes
Apr 21, 2025
9e8874a to
ba581d8
Compare
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.