[RTG] Add set_cartesian_product operation #8376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngar
approved these changes
Apr 21, 2025
Comment on lines
+278
to
+282
| if (operands.empty()) { | ||
| if (loc) | ||
| return mlir::emitError(*loc) << "at least one set must be provided"; | ||
| return failure(); | ||
| } |
There was a problem hiding this comment.
I think this was mentioned offline, but if you allow empty tuples, then the nullary cartesian product is usually {()}.
81e6118 to
0235439
Compare
508c62c to
f26a16f
Compare
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.