fix: correct --download-model to use HuggingFace URI instead of PVC #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RI - fixes regression from PR llm-d#320
nerdalert
pushed a commit
to nerdalert/llm-d-deployer
that referenced
this pull request
Jun 23, 2025
nerdalert
pushed a commit
to nerdalert/llm-d-deployer
that referenced
this pull request
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional fix needed for #320 to use HF and not PVC.
Current behavior: --download-model Qwen/Qwen3-0.6B → pvc://model-pvc/Qwen/Qwen3-0.6B → Broken hybrid mode
Fixed behavior: --download-model Qwen/Qwen3-0.6B → hf://Qwen/Qwen3-0.6B → Proper HuggingFace download
Tested full deployment ( now including looking into the pod )
INFO 06-18 01:46:26 [cli_args.py:297] non-default args: {'port': 8001, 'served_model_name': ['Qwen/Qwen3-0.6B']}