Skip to content

docs: Remove datasets.rst and fix llama-stack build commands #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

docs: Remove datasets.rst and fix llama-stack build commands #2061

merged 1 commit into from
May 6, 2025

Conversation

ChristianZaccaria
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria commented Apr 30, 2025 •
edited
Loading

Issue

Closes #2073

What does this PR do?

➜  llama-stack git:(remove-deprecated-rst) uv venv --python 3.10
source .venv/bin/activate
Using CPython 3.10.13 interpreter at: /usr/bin/python3.10
Creating virtual environment at: .venv
Activate with: source .venv/bin/activate
(llama-stack) ➜  llama-stack git:(remove-deprecated-rst) INFERENCE_MODEL=llama3.2:3b llama stack build --template ollama --image-type venv --run
zsh: llama: command not found...

Test Plan

To test: Run through rag_agent example in the detailed_tutorial.md file.

@facebook-github-bot
Copy link

Hi @ChristianZaccaria!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 30, 2025
@ChristianZaccaria ChristianZaccaria changed the title Remove datasets.rst and fix llama-stack build commands docs: Remove datasets.rst and fix llama-stack build commands Apr 30, 2025
leseb
leseb reviewed Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make sure the venv was sourced?

@ChristianZaccaria ChristianZaccaria force-pushed the remove-deprecated-rst branch from 352e11c to f68145e Compare May 1, 2025 09:22
@ChristianZaccaria ChristianZaccaria force-pushed the remove-deprecated-rst branch from f68145e to 8620739 Compare May 2, 2025 12:47
Bobbins228
Bobbins228 approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

leseb
leseb reviewed May 5, 2025
View reviewed changes
@raghotham
Copy link
Contributor

Can we change the RAG example in the notebook to be the same as the one in the quick start?

@leseb
Copy link
Collaborator

leseb commented May 6, 2025

Can we change the RAG example in the notebook to be the same as the one in the quick start?

This is important, but feels out of scope of this PR. @ChristianZaccaria would you to send a followup PR for that? Thanks!

@ashwinb ashwinb merged commit feb9eb8 into llamastack:main May 6, 2025
4 checks passed
@ChristianZaccaria
Copy link
Contributor Author

@raghotham great catch, thanks!
@leseb, absolutely, I will write a follow-up PR on this. Thank you!

@leseb
Copy link
Collaborator

leseb commented May 7, 2025

@raghotham great catch, thanks! @leseb, absolutely, I will write a follow-up PR on this. Thank you!

Thank you, appreciate that.

@ChristianZaccaria
Copy link
Contributor Author

ChristianZaccaria commented May 8, 2025 •
edited
Loading

Can we change the RAG example in the notebook to be the same as the one in the quick start?

@leseb @raghotham
Just to clarify, are we referring to completely changing this notebook: https://github.com/meta-llama/llama-stack/blob/main/docs/getting_started.ipynb ?

franciscojavierarceo pushed a commit to franciscojavierarceo/llama-stack that referenced this pull request May 9, 2025
@ChristianZaccaria @franciscojavierarceo
docs: Remove datasets.rst and fix llama-stack build commands (llamast…
ca781bd 
…ack#2061)

# Issue
Closes llamastack#2073 

# What does this PR do?
- Removes the `datasets.rst` from the list of document urls as it no
longer exists in torchtune. Referenced PR:
pytorch/torchtune#1781

- Added a step to run `uv sync`. Previously, I would get the following
error:

```
➜  llama-stack git:(remove-deprecated-rst) uv venv --python 3.10
source .venv/bin/activate
Using CPython 3.10.13 interpreter at: /usr/bin/python3.10
Creating virtual environment at: .venv
Activate with: source .venv/bin/activate
(llama-stack) ➜  llama-stack git:(remove-deprecated-rst) INFERENCE_MODEL=llama3.2:3b llama stack build --template ollama --image-type venv --run
zsh: llama: command not found...

```

[//]: # (If resolving an issue, uncomment and update the line below)
[//]: # (Closes #[issue-number])

## Test Plan

To test: Run through `rag_agent` example in the `detailed_tutorial.md`
file.

[//]: # (## Documentation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb approved these changes

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv

@vladimirivic vladimirivic Awaiting requested review from vladimirivic

@sixianyi0721 sixianyi0721 Awaiting requested review from sixianyi0721

@ehhuang ehhuang Awaiting requested review from ehhuang ehhuang is a code owner

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan terrytangyuan is a code owner

@SLR722 SLR722 Awaiting requested review from SLR722

+1 more reviewer

@Bobbins228 Bobbins228 Bobbins228 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: datasets.rst torchtune tutorial is deprecated
6 participants
@ChristianZaccaria @facebook-github-bot @raghotham @leseb @Bobbins228 @ashwinb