fix filename that was incorrect generated during 4.31.0 #6712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ranChangeSet = ranIndex.get(incorrectKey); | ||
| if (ranChangeSet != null) { | ||
| if (!checkLiquibaseVersionIs(ranChangeSet.getLiquibaseVersion(), 4, 31)) { | ||
| return null; |
There was a problem hiding this comment.
Maybe add a logging line here.
Comment on lines
+130
to
+133
| Scope.getCurrentScope().getSingleton(ExecutorService.class).getExecutor("jdbc", getDatabase()).execute(new UpdateChangeSetFilenameStatement | ||
| (changeSet, oldPath)); | ||
| getDatabase().commit(); | ||
| reset(); |
There was a problem hiding this comment.
Add some logging here explaining what is happening please.
abrackx
reviewed
Feb 7, 2025
| @@ -124,6 +125,14 @@ public void replaceChecksum(ChangeSet changeSet) throws DatabaseException { | |||
| reset(); | |||
| } | |||
|
|
|||
| @Override | |||
| public void replaceFilePath(ChangeSet changeSet, String oldPath) throws DatabaseException { | |||
There was a problem hiding this comment.
Is there any way to make this more targeted? And can we add a log about what's happening?
There was a problem hiding this comment.
I added another check in the calling class. Also, logs added!
wwillard7800
approved these changes
Feb 7, 2025
abrackx
approved these changes
Feb 7, 2025
StevenMassaro
approved these changes
Feb 7, 2025
suryaaki2
approved these changes
Feb 7, 2025
filipelautert
added a commit
that referenced
this pull request
Feb 10, 2025
* fix filename that was incorrect generated during 4.31.0 * chore: refactor and javadocs * chore: more javadocs * fix nullpointer; use correct method for logicalFilePath; logs * chore comments * fix another nullpointer * chore: adding integration tests * fix test title
suryaaki2
added a commit
that referenced
this pull request
Feb 11, 2025
fix filename that was incorrect generated during 4.31.0 (#6712) * fix filename that was incorrect generated during 4.31.0 * chore: refactor and javadocs * chore: more javadocs * fix nullpointer; use correct method for logicalFilePath; logs * chore comments * fix another nullpointer * chore: adding integration tests * fix test title Co-authored-by: suryaaki2 <80348493+suryaaki2@users.noreply.github.com>
filipelautert
added a commit
that referenced
this pull request
Feb 13, 2025
* fix filename that was incorrect generated during 4.31.0 * chore: refactor and javadocs * chore: more javadocs * fix nullpointer; use correct method for logicalFilePath; logs * chore comments * fix another nullpointer * chore: adding integration tests * fix test title (cherry picked from commit 08bedf1)
eichingertim
pushed a commit
to eichingertim/liquibase
that referenced
this pull request
May 10, 2025
) (liquibase#6716) fix filename that was incorrect generated during 4.31.0 (liquibase#6712) * fix filename that was incorrect generated during 4.31.0 * chore: refactor and javadocs * chore: more javadocs * fix nullpointer; use correct method for logicalFilePath; logs * chore comments * fix another nullpointer * chore: adding integration tests * fix test title Co-authored-by: suryaaki2 <80348493+suryaaki2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Things to be aware of
Things to worry about
Additional Context