Skip to content

Make changelog and change set logical file path settings override the setting from includeAll - Github issue 6493 #6494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

Make changelog and change set logical file path settings override the setting from includeAll - Github issue 6493 #6494

merged 1 commit into from
Nov 19, 2024

Conversation

wwillard7800
Copy link
Contributor

@wwillard7800 wwillard7800 commented Nov 6, 2024 •
edited
Loading

The changelog and changeset logical file paths were not superseding the one from includeAll

#6493

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@wwillard7800
Make changelog and change set logical file path settings override
f8f449f 
the setting from includeAll

Github issue 6493
@filipelautert filipelautert merged commit 0822cbd into master Nov 19, 2024
52 checks passed
@filipelautert filipelautert deleted the gh-issue-6493 branch November 19, 2024 12:18
@filipelautert filipelautert added this to the 1NEXT milestone Nov 19, 2024
catull pushed a commit to catull/liquibase that referenced this pull request Nov 20, 2024
@wwillard7800
Make changelog and change set logical file path settings override the…
b9a396e 
… setting from includeAll - Github issue 6493 (liquibase#6494)

Make changelog and change set logical file path settings override
the setting from includeAll

Github issue 6493
@Chris-1-000
Copy link

Was it intended to replace the logical file name from the imported changelog files with the one of the changelog file in which the import is defined?
In my example below all the change sets from included changelog files have the logical file path "usecase/changelog-master.xml" when using version 4.31.0. This has led to problems with the validation of the database schemas. As a workaround, we have removed the logical file path from the master file.

changelog-master.xml

<?xml version="1.0" encoding="UTF-8"?>
<databaseChangeLog
    xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd"
    logicalFilePath="usecase/changelog-master.xml">

  <include file="changelog-v1.xml" relativeToChangelogFile="true"/>
 <!-- more includes -->
</databaseChangeLog>

changelog-v1.xml

<?xml version="1.1" encoding="UTF-8" standalone="no"?>
<databaseChangeLog
    xmlns="http://www.liquibase.org/xml/ns/dbchangelog" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd"
    logicalFilePath="usecase/changelog-v1.xml">

  <changeSet id="tag-start" author="user">
    <tagDatabase tag="usecase-v1-start"/>
  </changeSet>
  <!-- more change sets -->
</databaseChangeLog>

@filipelautert
Copy link
Collaborator

Hi @Chris-1-000 - looks like this pr had some issues -> #6656 .
We have a fix here: #6664 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipelautert filipelautert filipelautert approved these changes

@abrackx abrackx abrackx approved these changes

@rberezen rberezen rberezen approved these changes

@tati-qalified tati-qalified tati-qalified approved these changes

@suryaaki2 suryaaki2 Awaiting requested review from suryaaki2

Assignees
No one assigned
Labels
manuallyTested TypeBug
Projects
Liquibase Open Source
Archived in project
Milestone
v4.31.0
Development

Successfully merging this pull request may close these issues.
6 participants
@wwillard7800 @Chris-1-000 @filipelautert @abrackx @rberezen @tati-qalified