-
Notifications
You must be signed in to change notification settings - Fork 1.9k
DAT-18250 DevOps :: Clean up branch build not working #6162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions to v3 to fix compatibility issue with current workflow configuration
filipelautert
approved these changes
Aug 4, 2024
…o be deleted before running delete action
…REF environment variable for branch name instead of github.event.ref to improve consistency and readability
…event.ref_name instead of GITHUB_REF to improve accuracy and consistency in versioning information displayed
…d store it in GITHUB_ENV for later use 🔧 (cleanup-branch-builds.yml): update version parameter to use the extracted branch name instead of github.event.ref_name to ensure correct version deletion
…fetch commits between current branch and master/release branches for cleanup purposes
…tore commits as a comma-separated list for better readability and consistency.
…lete based on commits between branch and release to streamline cleanup process.
… IDs using GitHub API for better readability and maintainability
…elete-sha-package' for clarity 🔧 (cleanup-branch-builds.yml): Add support for deleting DAT-SNAPSHOT Github Package for Branch based on branch name 🔧 (cleanup-branch-builds.yml): Update job to extract branch name and use it for deleting DAT-SNAPSHOT package versions
… code checkout step to simplify workflow and improve readability
…nment variable PACKAGE_IDS instead of steps output for better consistency and readability.
…c to use GitHub CLI for better readability and maintainability.
…thub Package for a specific branch to keep the repository clean and reduce clutter 🔧 (cleanup-branch-builds.yml): Update workflow to ensure that only the specific branch version is deleted when cleaning up DAT-SNAPSHOT Github Package
…ACKAGE_TYPE value to 'maven' for consistency
sayaliM0412
reviewed
Aug 5, 2024
… extract branch name into a separate job for reusability and readability 🔧 (.github/workflows/cleanup-branch-builds.yml): update references to branch name to use the extracted branch name output for consistency and accuracy
…to get-branch-name to match usage 🔧 (cleanup-branch-builds.yml): update output redirection to GITHUB_OUTPUT variable for correct output handling
sayaliM0412
approved these changes
Aug 6, 2024
filipelautert
pushed a commit
that referenced
this pull request
Aug 13, 2024
* ⬆️ (cleanup-branch-builds.yml): downgrade actions/delete-package-versions to v3 to fix compatibility issue with current workflow configuration * 📝 (cleanup-branch-builds.yml): add echo command to display versions to be deleted before running delete action * 🔧 (cleanup-branch-builds.yml): update version variable to use GITHUB_REF environment variable for branch name instead of github.event.ref to improve consistency and readability * 🔧 (cleanup-branch-builds.yml): update version variable to use github.event.ref_name instead of GITHUB_REF to improve accuracy and consistency in versioning information displayed * 🔧 (cleanup-branch-builds.yml): extract branch name from GITHUB_REF and store it in GITHUB_ENV for later use 🔧 (cleanup-branch-builds.yml): update version parameter to use the extracted branch name instead of github.event.ref_name to ensure correct version deletion * 🔧 (.github/workflows/cleanup-branch-builds.yml): improve workflow to fetch commits between current branch and master/release branches for cleanup purposes * 🔧 (.github/workflows/cleanup-branch-builds.yml): refactor script to store commits as a comma-separated list for better readability and consistency. * ✨ (cleanup-branch-builds.yml): prepare list of package versions to delete based on commits between branch and release to streamline cleanup process. * 🔧 (cleanup-branch-builds.yml): refactor script to get package version IDs using GitHub API for better readability and maintainability * 🔧 (.github/workflows/cleanup-branch-builds.yml): add GH_TOKEN environment variable to access GitHub API with authentication for querying package version IDs. * 🐛 (cleanup-branch-builds.yml): fix repository owner and name to "liquibase" and "liquibase" respectively for correct package version processing. * 🔧 (cleanup-branch-builds.yml): refactor GitHub API call to retrieve package version IDs using curl command for better readability and maintainability * 🔧 (cleanup-branch-builds.yml): add matrix strategy to define packages to delete dynamically based on the matrix values 🔧 (cleanup-branch-builds.yml): use GitHub API to fetch package version IDs for deletion instead of GraphQL query for better performance and efficiency * 🐛 (cleanup-branch-builds.yml): fix filtering logic to select package version by name instead of tags for cleanup process * 🔧 (cleanup-branch-builds.yml): Rename job from 'delete-package' to 'delete-sha-package' for clarity 🔧 (cleanup-branch-builds.yml): Add support for deleting DAT-SNAPSHOT Github Package for Branch based on branch name 🔧 (cleanup-branch-builds.yml): Update job to extract branch name and use it for deleting DAT-SNAPSHOT package versions * 🔧 (cleanup-branch-builds.yml): remove unnecessary matrix strategy and code checkout step to simplify workflow and improve readability * 🔧 (cleanup-branch-builds.yml): update conditional check to use environment variable PACKAGE_IDS instead of steps output for better consistency and readability. * 🔧 (cleanup-branch-builds.yml): refactor package version deletion logic to use GitHub CLI for better readability and maintainability. * ✨ (cleanup-branch-builds.yml): Add workflow to delete DAT-SNAPSHOT Github Package for a specific branch to keep the repository clean and reduce clutter 🔧 (cleanup-branch-builds.yml): Update workflow to ensure that only the specific branch version is deleted when cleaning up DAT-SNAPSHOT Github Package * 📝 (cleanup-branch-builds.yml): remove unnecessary comment and align PACKAGE_TYPE value to 'maven' for consistency * 🔧 (.github/workflows/cleanup-branch-builds.yml): refactor workflow to extract branch name into a separate job for reusability and readability 🔧 (.github/workflows/cleanup-branch-builds.yml): update references to branch name to use the extracted branch name output for consistency and accuracy * 🐛 (cleanup-branch-builds.yml): fix step id typo from get_branch_name to get-branch-name to match usage 🔧 (cleanup-branch-builds.yml): update output redirection to GITHUB_OUTPUT variable for correct output handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
⬆️ (cleanup-branch-builds.yml): downgrade actions/delete-package-versions to v3 to fix compatibility issue with current workflow configuration
Description
Things to be aware of
Things to worry about
Additional Context