Skip to content

Conversation

abrackx
Copy link
Contributor

@abrackx abrackx commented Aug 5, 2024

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Instead of replacing the executor with a logging executor, use UpdateCountSqlCommandStep and UpdateToTagSqlCommandStep in liquibase:updateSql.

Things to be aware of

Adds two new methods to Liquibase class. We haven't ever actually called out count or tag in any of our update method names before on this class, but update has been overloaded ad nauseam so I decided to just label these exactly as to what they are doing.

Things to worry about

Additional Context

abrackx added 2 commits August 5, 2024 15:52
…-to-tag-sql. Use these new methods in the `updateSql` mojo instead of overwriting the executor.
@suryaaki2 suryaaki2 merged commit a55d7e3 into master Aug 9, 2024
36 checks passed
@suryaaki2 suryaaki2 deleted the DAT-18323 branch August 9, 2024 13:29
filipelautert pushed a commit that referenced this pull request Aug 13, 2024
…AT-18323) (#6168)

* [DAT-18323] Add new liquibase methods for update-count-sql and update-to-tag-sql. Use these new methods in the `updateSql` mojo instead of overwriting the executor.

* [DAT-18323] Revert test change

* [DAT-18323] Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants